Fix Actions.elements does not emit values #231
Draft
Econa77 wants to merge 2 commits intoRxSwiftCommunity:masterfrom
Draft
Fix Actions.elements does not emit values #231Econa77 wants to merge 2 commits intoRxSwiftCommunity:masterfrom
Actions.elements does not emit values #231Econa77 wants to merge 2 commits intoRxSwiftCommunity:masterfrom
Conversation
Generated by 🚫 dangerJS |
Member
|
It's been a while since I used RxSwift day-to-day... is this a bad solution just because of the |
Member
Author
|
@ashfurrow I think the bad solution is an empty subscribe to keep the values emitting. This is necessary to subscribe to the values at any time, but it difficult to understand why this empty subscribe is needed on code. |
|
Any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #216
I encountered a case similar to the issue ( #216 ) and committed testing and a temporary fix. It seems that the values does not emit if the timing to subscribe the elements is after the input.
I don't think this fix is so good, so does anyone have any other ideas?