Add hospital service to pending transfers #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompson318
reviewed
Aug 6, 2025
…ss, but something is wrong as the hospital service doesn't seem to be in the right place of the HL7 message
…' into feature/pending-hospital-service
thompson318
reviewed
Aug 6, 2025
hl7-reader/src/main/java/uk/ac/ucl/rits/inform/datasources/ids/AdtMessageFactory.java
Outdated
Show resolved
Hide resolved
After careful investigation I think the tests files were slightly wrong as Stephen suggested
skeating
reviewed
Aug 10, 2025
Contributor
skeating
left a comment
skeating
left a comment
There was a problem hiding this comment.
We need Stef to look at this
hl7-reader/src/main/java/uk/ac/ucl/rits/inform/datasources/ids/AdtMessageFactory.java
Outdated
Show resolved
Hide resolved
thompson318
reviewed
Aug 13, 2025
hl7-reader/src/main/java/uk/ac/ucl/rits/inform/datasources/ids/hl7/parser/PV1Wrap.java
Outdated
Show resolved
Hide resolved
thompson318
reviewed
Aug 13, 2025
...src/main/java/uk/ac/ucl/rits/inform/datasinks/emapstar/controllers/PendingAdtController.java
Outdated
Show resolved
Hide resolved
skeating
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have set up test cases for adding hospital service (In Epic, this is called sub-speciality) to the pending transfers. I think implmementing it should be slotting into the existing structure in the hl7-reader and then again in emap core
#95