- 
                Notifications
    
You must be signed in to change notification settings  - Fork 615
 
feat: creating kaniko build artifact metadata #5435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           @anilkeshav27 Please add tests to the new functions introduced  | 
    
| 
               | 
          ||
| // syft sbom do not contain purl for the parent component | ||
| // this is problem since the way we tie back promoted artifact to build | ||
| // is only via the sbom parent componen , untill the time https://github.com/anchore/syft/issues/1408 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be tracked by DMS or sentinel to make the change when the issue is fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently there is no plan from the syft team itself for the fix so its hard to commit, but whenever the sbom topic is handelled centrally will hand over
| 
           @anilkeshav27 When I tried to build multiple images I get wrong buildPath for example: Project structure: For all the Dockerfiles the BuildPath is root directory as value ".", the path to the build descriptor is essential isn't it?  | 
    
          
 currently the buildPath is not needed for downstream application, but i can take it up as a follow up task to fix after this PR  | 
    
          
 have included the unit test  | 
    
          
 My understanding for signature scan is, SBOM and its corresponding build descriptor path are required. Could you please confirm again this is not the case?  | 
    
          
 | 
    
| 
           /it-go  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 
           Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add   | 
    



Description
Checklist