Skip to content

Conversation

@anilkeshav27
Copy link
Member

Description

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@anilkeshav27 anilkeshav27 requested a review from a team as a code owner August 1, 2025 21:25
@manjunathSurendrakumar
Copy link
Member

@anilkeshav27 Please add tests to the new functions introduced


// syft sbom do not contain purl for the parent component
// this is problem since the way we tie back promoted artifact to build
// is only via the sbom parent componen , untill the time https://github.com/anchore/syft/issues/1408

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be tracked by DMS or sentinel to make the change when the issue is fixed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently there is no plan from the syft team itself for the fix so its hard to commit, but whenever the sbom topic is handelled centrally will hand over

@manjunathSurendrakumar
Copy link
Member

@anilkeshav27 When I tried to build multiple images I get wrong buildPath for example:

Project structure:
multi-docker/sub-dir1/Dockerfile
multi-docker/sub-dir2/Dockerfile
Dockerfile

For all the Dockerfiles the BuildPath is root directory as value ".", the path to the build descriptor is essential isn't it?

@anilkeshav27
Copy link
Member Author

anilkeshav27 commented Aug 13, 2025

@anilkeshav27 When I tried to build multiple images I get wrong buildPath for example:

Project structure: multi-docker/sub-dir1/Dockerfile multi-docker/sub-dir2/Dockerfile Dockerfile

For all the Dockerfiles the BuildPath is root directory as value ".", the path to the build descriptor is essential isn't it?

currently the buildPath is not needed for downstream application, but i can take it up as a follow up task to fix after this PR

@anilkeshav27
Copy link
Member Author

@anilkeshav27 Please add tests to the new functions introduced

have included the unit test

@manjunathSurendrakumar
Copy link
Member

@anilkeshav27 When I tried to build multiple images I get wrong buildPath for example:
Project structure: multi-docker/sub-dir1/Dockerfile multi-docker/sub-dir2/Dockerfile Dockerfile
For all the Dockerfiles the BuildPath is root directory as value ".", the path to the build descriptor is essential isn't it?

currently the buildPath is not needed for downstream application, but i can take it up as a follow up task to fix after this PR

My understanding for signature scan is, SBOM and its corresponding build descriptor path are required. Could you please confirm again this is not the case?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

@manjunathSurendrakumar
Copy link
Member

/it-go

Copy link
Member

@manjunathSurendrakumar manjunathSurendrakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale marks stale issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants