fix(adp): Problems with login in the Replace OData Service change editor. #3846
+52
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…does not succeed.
🦋 Changeset detectedLatest commit: 6c5c55e The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
avasilev-sap
changed the title
…m the lrep service not from the provider instance.
mmilko01
approved these changes
Nov 20, 2025
Contributor
mmilko01
left a comment
mmilko01
left a comment
There was a problem hiding this comment.
Changeset OK
Changes look good
Excellent test coverage
Did not test manually
|
IvoSG
approved these changes
Nov 21, 2025
Contributor
IvoSG
left a comment
IvoSG
left a comment
There was a problem hiding this comment.
Changes look good
Good test coverage
Did not test manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3845
undefinedas a text in the label, this PR fixes the initialization issue and removes some dead-code.getUI5SystemVersionapi call to check if the user is logged in. Recently the version api has changed and is now public so the api always returns status 200. From now on we start to rely on thegetSystemInfoapi call to verify if user is logged in since the api is a protected one. We needed to adjust the stub method getSystemInfo to throw any errors from the actual api call, prior this PR the errors were hidden and just being logged in.Testing done: