-
Notifications
You must be signed in to change notification settings - Fork 53
feat: New public method for ApplicationAccess - readManifest, readFlexChanges, readAnnotationFiles
#3854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
new public methods for application access
🦋 Changeset detectedLatest commit: c671b49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 49 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
review comments
Klaus-Keller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @815are!
- Added functions to application access reviewed
- changeset exists
- test coverage is good
- did a visual review, no manual test
Approved from my side
broksy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset reflects to the changes made, test coverage is good, approved from my side.
|
* main: chore: apply latest changesets Bug - Fix npm install for CAP when adding first app so that preview works after install. (#3862) chore: apply latest changesets Fix(cap-config-writer): min cds version (#3856) feat: New public method for `ApplicationAccess` - `readManifest`, `readFlexChanges`, `readAnnotationFiles` (#3854) chore: apply latest changesets fix: System SAPUI5 version not available for selection in ADP generator (#3851)



New public method for
ApplicationAccessreadManifest- reads and returns the parsedmanifest.jsonfile for the application.readFlexChanges- reads and returns all Flex Changes (*.changefiles) associated with the application.readAnnotationFiles- reads and returns all annotation files associated with the application's main service.