Skip to content

CAFMaker Truth Bugfix #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjplows merged 4 commits into from
Jan 16, 2026
+1 −1
Merged

CAFMaker Truth Bugfix #623

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ed57fe
Fix some loop bonuds
nathanielerowe Jan 14, 2026
a21662e
revert change to 2x3 arrays
nathanielerowe Jan 14, 2026
df24238
make sure all planes filled
nathanielerowe Jan 14, 2026
517fcb3
Merge branch 'develop' into bugfix/ncryo
kjplows Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sbncode/CAFMaker/FillTrue.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ namespace caf {
}

// Set the cryostat of the position
for (int icryo = 0; icryo < 2; icryo++) {
for (int icryo = 0; icryo < (int)active_volumes.size(); icryo++) {
Copy link
Member

@PetrilloAtWork PetrilloAtWork Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it would be more correct to have icryo of index type (std::size_t) since its name suggest it being an index, and then converted in the assignment on line 604.
But I will let it pass; it's mostly to prove that I can make a comment also to a one-liner.

if (active_volumes[icryo].ContainsPosition(nu.Nu().Position().Vect())) {
srneutrino.cryostat = icryo;
break;
Expand Down