Merge 20251021 #499
Closed
Merge 20251021 #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case ignore_noent is specified, ignore files removed during relabeling (race condition between folder read, file read and label set). Signed-off-by: Vit Mojzis <[email protected]> Acked-by: Stephen Smalley <[email protected]>
editorconfig is a standardised way to configure editors for a project. Based off the Linux kernel .editorconfig file. Signed-off-by: Rahul Sandhu <[email protected]> Acked-by: Stephen Smalley <[email protected]>
Add the .clang-format configuration file, taken from the Linux kernel repository. We don't have any official style guidelines in tree at present, which makes it a bit unclear how to format C code for new contributors. As well as this, different parts of the codebase seem to been formatted with different styles on occasion, so using an automatic formatter should resolve this. As well as this, replace all the existing indent targets with a single toplevel `format` target. Managing all the source files to be formatted is not pretty to maintain, and doesn't really give us much. Also define a toplevel `check-format` target to verify that all code is formatted properly. This only becomes useful in the future once we have reformatted all existing code, but is wired up for now. For the future: 1. Reformat all existing code. I understand this is a big change, but we may as well get all code formatted if we go down this route; afterall, it's not like this will cause any breaking changes. 2. Add a CI target to check that all code is formatted as per the new clang-format configuration. The `check-format` target can be used for this. Signed-off-by: Rahul Sandhu <[email protected]> Acked-by: Stephen Smalley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md
Contributing Code
Post the patch for the review to the
SELinux mailing list at
[email protected].
When preparing patches, please follow these guidelines:
code meets the Developer's certificate of origin, see below.