Make TLS client cert/key file optional #601
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdoekes
reviewed
Dec 6, 2022
|
|
||
| if (SSL_CTX_use_PrivateKey_file(sip_trp_ssl_ctx, | ||
| tls_key_name, | ||
| SSL_FILETYPE_PEM) != 1) { |
Member
There was a problem hiding this comment.
For indentation all the way to the right, please indent exactly to after the (, like above.
| ERR_error_string_n(ERR_get_error(), errbuf, sizeof(errbuf)); | ||
| ERROR("TLS_init_context: SSL_CTX_use_certificate_file (client) failed: %s", errbuf); | ||
| return TLS_INIT_ERROR; | ||
| } |
Member
There was a problem hiding this comment.
Is a client cert now optional? Or is it not possible anymore?
smititelu
force-pushed
the
tls_client_cert_key
branch
from
47142cb to
0523920
Compare
smititelu
force-pushed
the
tls_client_cert_key
branch
from
0523920 to
4a7bccb
Compare
Contributor
Author
|
Updated PR to use client cert only if key/cert files exist at that path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow start of sipp TLS client, without a mandatory cert/key.
related to #569