Skip to content

Conversation

@timleg002
Copy link

This new method allows accessing the entire data buffer of a FrameData. Useful for rendering raw pixel data to the screen.

@timleg002 timleg002 requested a review from a team as a code owner August 23, 2025 14:25
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2025

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.95%. Comparing base (a9e984d) to head (60cde54).
⚠️ Report is 852 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/ffmpeg/src/frame.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   78.96%   78.95%   -0.02%     
==========================================
  Files         327      327              
  Lines       24383    24343      -40     
==========================================
- Hits        19255    19220      -35     
+ Misses       5128     5123       -5     
Files with missing lines Coverage Δ
crates/ffmpeg/src/frame.rs 87.99% <0.00%> (-1.32%) ⬇️

... and 3 files with indirect coverage changes

Components Coverage Δ
scuffle-aac 89.47% <ø> (ø)
scuffle-amf0 90.31% <ø> (ø)
scuffle-av1 98.40% <ø> (ø)
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 86.72% <ø> (ø)
scuffle-bytes-util 96.70% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-expgolomb 100.00% <ø> (ø)
scuffle-ffmpeg 89.78% <0.00%> (-0.36%) ⬇️
scuffle-flv 95.59% <ø> (ø)
scuffle-future-ext 50.00% <ø> (ø)
nutype-enum 71.87% <ø> (ø)
scuffle-h264 99.68% <ø> (ø)
scuffle-http 85.46% <ø> (ø)
scuffle-metrics 86.07% <ø> (ø)
postcompile 81.52% <ø> (ø)
scuffle-pprof 100.00% <ø> (ø)
scuffle-rtmp 90.88% <ø> (-0.28%) ⬇️
scuffle-settings 93.44% <ø> (ø)
scuffle-signal 95.41% <ø> (+9.60%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SimaoMoreira5228
Copy link
Contributor

Hi, thanks for the contributions!
To fix the fmt stage, you should be able to run the just fmt command. If you don’t want to install just, you can check the justfile and run the corresponding command manually.

Regarding the Release Checks issue: you’ll need to add a changelog entry to your PR, describing the changes you made. There’s an example file in the changes.d folder that you can follow.

@timleg002 timleg002 requested a review from a team as a code owner August 23, 2025 14:48
@philipch07
Copy link
Member

In addition to @SimaoMoreira5228 's comments, it may be nice to have a simple test or two to ensure that the output is correct. Since it's returning raw data, using snap would likely prove to be useful here. We have many tests that use snap so feel free to pick any of them as an example to go off of.

Thank you for the contribution!

}

/// Returns the entire data buffer
pub fn get_all(&self) -> &[u8] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a huge fan of the name of this function. I think we should also add a comment about alignment / padding values. Perhaps get_buffer

Since these lines also include the padding values / alignment and is not just the raw frame data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants