Skip to content

Conversation

@billy1624
Copy link
Member

@billy1624 billy1624 commented May 17, 2025

Breaking Changes

  • Update to Rust Edition 2024
  • Update Minimum Supported Rust Version (MSRV) to Rust 1.85.0

@billy1624 billy1624 marked this pull request as ready for review May 17, 2025 08:49
@billy1624 billy1624 requested a review from tyt2y3 May 17, 2025 08:49
@tyt2y3
Copy link
Member

tyt2y3 commented Aug 20, 2025

we should delay this after the 1.x branch is feature frozen
right now we're still continuously rebasing master onto 1.x

@tyt2y3 tyt2y3 force-pushed the main branch 2 times, most recently from 2de933f to d24a975 Compare August 27, 2025 08:48
@tyt2y3 tyt2y3 force-pushed the main branch 7 times, most recently from c7e23e4 to 1e40248 Compare September 2, 2025 12:48
@tyt2y3 tyt2y3 force-pushed the main branch 9 times, most recently from 5801629 to f19754c Compare September 6, 2025 21:18
@tyt2y3 tyt2y3 force-pushed the main branch 7 times, most recently from 4e9008c to ff350b4 Compare September 20, 2025 14:37
@tyt2y3 tyt2y3 force-pushed the main branch 6 times, most recently from a9b503f to 6b1ff0a Compare September 23, 2025 22:36
@SindriFr
Copy link

I suggest also updating the macro crate to the 2024 edition and minimum rust version 1.88 (rust issue

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/custom_fields.rs:85:8
   |
85 |     if let Some(arg) = args.get(argno)
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:171:8
    |
171 |     if let FnArg::Typed(pat) = arg
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:172:12
    |
172 |         && let Type::Reference(TypeReference { elem, .. }) = &*pat.ty
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:173:12
    |
173 |         && let Type::Path(path) = elem.as_ref()
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> macros/src/custom_fields.rs:174:12
    |
174 |         && let Some(last_segment) = path.path.segments.last()
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/util.rs:32:45
   |
32 |                 let inner_name: String = if let Some(first) = unnamed.unnamed.first()
   |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/util.rs:33:24
   |
33 |                     && let Type::Path(path) = &first.ty
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
  --> macros/src/util.rs:35:24
   |
35 |                     && let Some(seg) = path.path.segments.first()
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `seaography-macros` (lib) due to 8 previous errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants