Block Partners API for 3P devs

[gonzaloriestra]

WHY are these changes introduced?

Only 1P devs still need Partners API, so we can avoid additional API calls for the rest

WHAT is this pull request doing?

• Blocks Partners API when SHOPIFY_CLI_NEVER_USE_PARTNERS_API is set or SHOPIFY_CLI_1P_DEV is not set
• Makes App Management API the default API

How to test your changes?

• p shopify app init --template none --verbose => No Partners
• SHOPIFY_CLI_1P_DEV=1 p shopify app init --template none --verbose => uses Partners
• SHOPIFY_CLI_NEVER_USE_PARTNERS_API=1 SHOPIFY_CLI_1P_DEV=1 p shopify app init --template none --verbose => No Partners

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	79.19% (-0.03% 🔻)	13611/17187
🟡	Branches	73.11% (+0% 🔼)	6638/9079
🟡	Functions	79.32% (-0.05% 🔻)	3510/4425
🟡	Lines	79.55% (-0.03% 🔻)	12855/16159

Show new covered files 🐣

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / bulk-operation-run-query.ts	100%	100%	100%	100%
🟢	... / execute-bulk-operation.ts	100%	83.33%	100%	100%
🟢	... / run-query.ts	100%	100%	100%	100%

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / developer-platform-client.ts	84.62% (-1.5% 🔻)	73.68% (+3.1% 🔼)	81.82% (+1.82% 🔼)	90.63% (-2.71% 🔻)
🟢	... / ConcurrentOutput.tsx	98.36% (-1.64% 🔻)	92% (-4% 🔻)	100%	98.33% (-1.67% 🔻)
🔴	... / ui.tsx	50.82% (-0.79% 🔻)	42.86% (-5.53% 🔻)	54.55% (+1.42% 🔼)	50% (-0.82% 🔻)
🟡	... / theme-environment.ts	69.57% (-1.86% 🔻)	50%	55.56% (-3.27% 🔻)	69.57% (-1.86% 🔻)

Test suite run success

3361 tests passing in 1376 suites.

Report generated by 🧪jest coverage report action from 589cb8d

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/environment.d.ts

@@ -53,7 +53,7 @@ export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): bool
 /**
  * If true, the CLI should not use the Partners API.
  *
- * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
+ * @returns True when SHOPIFY_CLI_NEVER_USE_PARTNERS_API is set or SHOPIFY_CLI_1P_DEV is not set.
  */
 export declare function blockPartnersAccess(): boolean;
 /**

[alfonso-noriega]

LGTM!🚀

[nickwesselman]

• Allow non-interactive app init #6640
• Block Partners API for 3P devs #6645 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.