-
Notifications
You must be signed in to change notification settings - Fork 224
Support flexible templates for app init
#6751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shauns
wants to merge
1
commit into
main
Choose a base branch
from
shauns/01-09-support_flexible_templates_for_app_init_
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3611 tests passing in 1423 suites. Report generated by 🧪jest coverage report action from 770bb28 |
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
5599003 to
770bb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Fixes an issue where app templates using certain module types cause
app initto fail. The issue is due to the app template using module types that aren't defined within the CLI, but more generally due toapp initvalidating/understanding app configuration.WHAT is this pull request doing?
Instead, we process app config during app instantiation as opaque blobs -- we don't rely on being able to validate them or a particular structure being in place.
In
app initthe app is loaded twice -- once as a template, and then again as the local copy of the app is linked to the remote version of it.How to test your changes?
Locally:
pnpm shopify app init --path="<where I keep my apps>" --template="https://github.com/Shopify/shopify-app-template-react-router#include-declarative-definition"Measuring impact
How do we know this change was effective? Please choose one:
Checklist