-
Notifications
You must be signed in to change notification settings - Fork 123
chore: metrics doc revamp #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…e/metrics-explorer-doc-revamp
…e/metrics-explorer-doc-revamp
…e/metrics-explorer-doc-revamp
…etrics via Prometheus and OTel Collector, introducing a metrics quick start component, and updating the metrics query API.
…tting in metrics API.
…ew tabs and revise examples.
… general guide and simplifying the Prometheus metrics setup.
…c note and adding a tip for finding keys in the UI.
…verview - Introduce SectionId type alias to ensure type safety for category props - Add explicit typing to sections array and activeSection state to eliminate 'any' casts - Update AWS ECS Fargate and EC2 hrefs to new OpenTelemetry documentation paths for accuracy
|
@claude /review |
|
Claude finished @makeavish's task —— View job PR Review CompleteReviewed PR #2087: chore: metrics doc revamp SummaryThis PR restructures the metrics documentation with improved organization and new guides. The changes include:
Issues FoundI've created 5 inline comments for issues that need to be addressed:
All links should point to Technical Accuracy✅ Verified against official OpenTelemetry sources:
PR Checklist ReviewPer CONTRIBUTING.md guidelines:
Recommendations
Overall, this is a solid refactor that improves documentation structure. Once the broken links are fixed, this will be ready to merge. |
No description provided.