Fix, cleanup, and optimize new cloud provider code. #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves cloud provider code by fixing resource disposal issues, renaming APIs for clarity, and fixing typos. The main focus is on ensuring AWS S3 clients are properly disposed after use to prevent resource leaks.
- Introduces proper resource disposal for AWS S3 clients by implementing IDisposable pattern
- Renames factory methods and properties for better API clarity (e.g., "Provider" → "Factory")
- Fixes spelling errors and typos throughout the codebase
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AWSS3StorageImageProviderFactory.cs | Updates test utilities to use new client wrapper and fixes spelling error |
| AWSS3StorageCacheTestServerFixture.cs | Removes service provider parameter from cache creation |
| AWSS3StorageCacheCacheFolderTestServerFixture.cs | Removes service provider parameter from cache creation |
| AzureBlobStorageImageProviderOptions.cs | Renames provider properties to factory and fixes spelling |
| AzureBlobStorageImageProvider.cs | Updates to use renamed factory properties and fixes typos |
| AzureBlobStorageCacheOptions.cs | Renames provider property to factory |
| AzureBlobStorageCache.cs | Updates to use renamed factory property |
| AWSS3StorageImageProviderOptions.cs | Updates interface to use new client wrapper type |
| AWSS3StorageImageProvider.cs | Implements IDisposable and uses new client wrapper |
| IAWSS3BucketClientOptions.cs | Updates interface with new factory pattern and improves documentation |
| AWSS3StorageCacheOptions.cs | Updates to use new client wrapper type |
| AWSS3StorageCache.cs | Implements IDisposable and uses new client wrapper |
| AmazonS3ClientFactory.cs | Updates factory to return new wrapper type |
| AmazonS3BucketClient.cs | New wrapper class for Amazon S3 client with disposal management |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Following #361 and #362
This PR does some API cleanup and fixes. Some of the changes are breaking but are required to fix an issue where Amazon clients were not disposed after use.