Skip to content

Implement converting PageContent's into HTML #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
paypur wants to merge 40 commits into
base: 1.20
Choose a base branch
from
Open

Implement converting PageContent's into HTML #231

paypur wants to merge 40 commits into from

Conversation

@paypur
Copy link

@paypur paypur commented Jul 16, 2025

paypur added 12 commits July 10, 2025 11:44
@paypur
Modified the book export command to also export HTML
cd3b0cc 
Implemented IHTML for everything in Materials and You


Took 1 minute
@paypur
Disabled rendering text while using the book export command
4832a04 
Took 15 minutes
@paypur
Added linking between content
0e05794 
Took 1 hour 54 minutes
@paypur
Added partial styling support TextData for text using Minecraft's cha…
688b88c 
…t formatting system

Took 1 hour 57 minutes
@paypur
Fixed issue with chat formatting parser skipping text after the last …
380b5c6 
…formatting code
@paypur
Fixed NPE for toHTML(TextData[])
3b57a1f
@paypur
Updated HTMLUtils
4a1cfef
@paypur
Updated titles to use isCentered and isLarge
7a96272 
Took 2 hours 12 minutes
@paypur
Added dark blue to TextData#parseChatFormatting
bd7e363 
Took 14 minutes
@paypur
Updated ContentSectionList to allow for a 4th column
ea99169 
Took 9 minutes
@paypur
Did something
f27fa6e
@paypur
Reverted build.gradle
9b3a129 
Took 38 seconds
@paypur paypur marked this pull request as draft July 16, 2025 20:29
@paypur paypur mentioned this pull request Jul 16, 2025
Open
@KnightMiner
Copy link
Member

KnightMiner commented Jul 16, 2025

Its also worth asking, do you plan to implement tooltips or not? Its fine without tooltip; text + links is better than nothing. But want to know so I know how to review this.

KnightMiner
KnightMiner reviewed Jul 16, 2025
View reviewed changes
KnightMiner
KnightMiner reviewed Jul 16, 2025
View reviewed changes
@paypur
Copy link
Author

paypur commented Jul 16, 2025 •
edited
Loading

I'll try but not in this pr

paypur added 2 commits July 16, 2025 18:32
@paypur
Added some javadocs
487e960 
Removed unnecessary spans and colors

Took 3 hours 23 minutes
@paypur
Moved exporting HTML to its own subcommand
9fb7e52 
Took 1 hour 45 minutes
fuj1n
fuj1n reviewed Jul 17, 2025
View reviewed changes
src/main/java/slimeknights/mantle/client/book/IHTML.java Outdated
Comment on lines 8 to 9
Mantle.logger.warn("{} does not implement IHTML. If it does not contain text, ignore this warning.", this.getClass());
return "<p>" + this.getClass() + "</p>";
Copy link
Member

@fuj1n fuj1n Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this default implementation is redundant and is probably better left out, since it is implemented on the base PageContent, and any subsequent child content inherits that.

Copy link
Author

@paypur paypur Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want to keep this though, it makes figuring out which class to work on very easy

Copy link
Member

@KnightMiner KnightMiner Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth making it abstract in the interface, but then put this default implementation in PageContent. Are there any other classes that implement the interface without providing an implementation?

Copy link
Author

@paypur paypur Jul 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the implementation in PageContent, so everything else I haven't changed

paypur added 8 commits July 17, 2025 08:40
@paypur
Moved some stuff
1a7b5cf 
Took 12 minutes
@paypur
Added back IHTML
4ec3987 
Took 9 minutes
@paypur
Merged book commands
fe1be52 
Took 15 minutes
@paypur
Removed instanceof checks
5e2a17d 
Took 11 minutes
@paypur
Removed empty div's
c638274 
Added another title helper

Took 30 minutes
@paypur
Mostly fixed ContentListing
4d5b061 
Took 39 minutes
@paypur
Changed href format
77435f3 
Took 23 minutes
@paypur
Changed TextData#toHTML to replace text lists with HTML lists
25ca86f 
Took 1 hour 55 minutes
@paypur paypur changed the title Implement converting most PageContent's into HTML Implement converting PageContent's into HTML Jul 20, 2025
@paypur paypur marked this pull request as ready for review July 20, 2025 23:20
paypur and others added 18 commits July 20, 2025 17:03
@paypur
Something
51320dc 
Took 16 minutes
@paypur
Merge remote-tracking branch 'origin/1.20' into 1.20_wiki
dec9c19 
# Conflicts:
#	src/main/java/slimeknights/mantle/client/screen/book/BookScreen.java
@paypur
Oops
91f9a64 
Took 8 seconds
@paypur
Fixed linking issues
5b284e6 
Took 2 hours 8 minutes
@paypur
Added front matter to HTML
a90a20c 
Took 1 hour 1 minute
@paypur
Fixed linking between individual book pages
e74da24 
Took 2 hours 37 minutes
@paypur
Fixed unnecessary redirect
2ac868f 
Took 42 minutes
@paypur
Added helper for faster exports
76c9f13 
Took 10 minutes
@paypur
Fixed ContentTextImage
1db4653 
Took 35 minutes
@paypur
Update ContentBlockInteraction.java
5433dda
@paypur
Added tooltips to icon links
3eeb1e1 
Took 44 minutes


Took 5 minutes
@paypur
Added minetip data to HTMLUtils.line helper
5e48a35 
Took 31 minutes
@paypur
Merge remote-tracking branch 'upstream/1.20' into 1.20_wiki
63a8e6f
@paypur
Rewrote HTMLUtils helpers
cc58217 
Took 1 hour 57 minutes
@paypur
Merge remote-tracking branch 'upstream/1.20' into 1.20_wiki
aa91679 
# Conflicts:
#	src/main/java/slimeknights/mantle/client/screen/book/BookScreen.java
#	src/main/java/slimeknights/mantle/command/client/BookCommand.java

Took 15 seconds
@paypur
Merge remote-tracking branch 'origin/1.20_wiki' into 1.20_wiki
88ceff0
@paypur
Fixed newline separated lines
1427cc2 
Took 44 minutes
@paypur
Fixed ContentListing overflowing
2dc61f5 
Took 29 minutes

Took 24 seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuj1n fuj1n fuj1n left review comments

@KnightMiner KnightMiner KnightMiner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paypur @KnightMiner @fuj1n