xwm: Use hidden in method names instead of minimized/suspended
#1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smithay#1482 renamed `set_minimized()` to `set_suspended()`, but didn't rename `is_minimized()`. But the name may not be ideal either. https://specifications.freedesktop.org/wm-spec/latest/ar01s05.html says > _NET_WM_STATE_HIDDEN should be set by the Window Manager to indicate > that a window would not be visible on the screen if its > desktop/viewport were active and its coordinates were within the > screen bounds. The canonical example is that minimized windows should > be in the _NET_WM_STATE_HIDDEN state. Pagers and similar applications > should use _NET_WM_STATE_HIDDEN instead of WM_STATE to decide whether > to display a window in miniature representations of the windows on a > desktop. While https://wayland.app/protocols/xdg-shell#xdg_toplevel:enum:state:entry:suspended says: > The surface is currently not ordinarily being repainted; for example > because its content is occluded by another window, or its outputs are > switched off due to screen locking. So `_NET_WM_STATE_HIDDEN` shouldn't be set merely because a window is occluded, or on a different workspace? Both definitions could perhaps be a bit more precise. It seems to me `_NET_WM_STATE_HIDDEN` is broader than "minimized", but more specific than the xdg-shell "suspended" state. So just call it "hidden" instead of using some other name.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1833 +/- ##
==========================================
- Coverage 19.15% 17.17% -1.98%
==========================================
Files 177 177
Lines 27865 27865
==========================================
- Hits 5337 4787 -550
- Misses 22528 23078 +550
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1482 renamed
set_minimized()toset_suspended(), but didn't renameis_minimized().But the name may not be ideal either.
https://specifications.freedesktop.org/wm-spec/latest/ar01s05.html says
While
https://wayland.app/protocols/xdg-shell#xdg_toplevel:enum:state:entry:suspended says:
So
_NET_WM_STATE_HIDDENshouldn't be set merely because a window is occluded, or on a different workspace? Both definitions could perhaps be a bit more precise.It seems to me
_NET_WM_STATE_HIDDENis broader than "minimized", but more specific than the xdg-shell "suspended" state. So just call it "hidden" instead of using some other name.