-
Notifications
You must be signed in to change notification settings - Fork 271
Read private key from env #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Read private key from env #338
Conversation
|
Thanks for the PR @fmterrorf! Ideally, we would like to leverage the environment variables for these credentials if possible. Does providing those with either SNOWFLAKE_PRIVATE_KEY_PATH or SNOWFLAKE_PRIVATE_KEY_RAW work for you? These credential environment variables are documented at https://docs.snowflake.com/en/developer-guide/snowflake-cli/connecting/configure-connections#use-environment-variables-for-snowflake-credentials. |
|
@sfc-gh-twhite I've tried |
|
@sfc-gh-twhite is there an ETA on when this enhancement will be released? |
|
@andrew-davey 4.1.0 is going to be released soon. As for the specific private key issue, we will prioritize this immediately after 4.1.0 release this week and include it in the 4.2.0 release before the holidays in December. Thank you for your contribution. Once 4.1.0 is released, if you could update your contribution to be based on as an bug fix to 4.1.0 would be appreciated. |
|
@fmterrorf 4.1.0 has addressed backward compatibility with mismatched variable names in favor of aligning with python connector's parameter names. Could you retest this PR against 4.1.0 and confirm if you still need to merge this PR or can close this out. We sincerely appreciate your patience and your contribution to the project. We are trying to streamline a predictable release cadence and staying on top of requests and will need time to catch up. Kindly respond back with your tests and resolving the merge conflict if you want the PR to be merged to master. |
sfc-gh-tmathew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you attempt to resolve the merge conflicts and let us know soon enough to include the PR in 4.2.0 OR we can slate it for a later release.
|
@sfc-gh-tmathew sorry i currently don't have time to do so. I'll probably get to it this weekend |
Adds an ability to read private key from an environment variable
SNOWFLAKE_PRIVATE_KEY