refactor: remove duplicate package import #1645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigmoonbit <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR removes duplicate package imports in the Ethereum connection handler to improve code cleanliness and readability.
- Removed duplicate imports of
github.com/ethereum/go-ethereum(aliased asgoEthereum) andgithub.com/sirupsen/logrus(aliased aslog) - Updated all references to use the non-aliased package names (
ethereumandlogrus)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
It seems that the CI failure is unrelated to this change Run actions/labeler@v5
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Warning: The action requires write permission to add labels to pull requests. For more information please refer to the action documentation: https://github.com/actions/labeler#permissions
Error: Resource not accessible by integration |
claravanstaden
requested changes
Dec 8, 2025
| "github.com/snowfork/snowbridge/relayer/config" | ||
| "github.com/snowfork/snowbridge/relayer/crypto/secp256k1" | ||
|
|
||
| log "github.com/sirupsen/logrus" |
Contributor
There was a problem hiding this comment.
Can you please keep this import and remove the "github.com/sirupsen/logrus" one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/ethereum/go-ethereumandgithub.com/sirupsen/logruswere imported twice.Remove the duplicate import to make the code cleaner and more readable.