-
Notifications
You must be signed in to change notification settings - Fork 137
Improve the tests and increase coverage #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Seperate sample quorum * Rename to computeMaxRequiredSignatures
…owbridge into ron/fix-quorum-check
|
|
||
| function deposit() external payable {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, originally agents paid/collected fees in v1, and this deposit was here as an explicit way to top up or balance agents. But I think we can remove it now.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
==========================================
+ Coverage 86.40% 91.02% +4.62%
==========================================
Files 21 19 -2
Lines 934 903 -31
Branches 164 164
==========================================
+ Hits 807 822 +15
+ Misses 102 64 -38
+ Partials 25 17 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alistair-singh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
|
|
||
| function deposit() external payable {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, originally agents paid/collected fees in v1, and this deposit was here as an explicit way to top up or balance agents. But I think we can remove it now.
|
@copilot Please review this pull request. |
No description provided.