Skip to content

Conversation

@yrong
Copy link
Contributor

@yrong yrong commented Dec 22, 2025

No description provided.

Comment on lines -32 to -33

function deposit() external payable {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, originally agents paid/collected fees in v1, and this deposit was here as an explicit way to top up or balance agents. But I think we can remove it now.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.02%. Comparing base (ba20bc6) to head (94e223d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/src/BeefyClient.sol 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
+ Coverage   86.40%   91.02%   +4.62%     
==========================================
  Files          21       19       -2     
  Lines         934      903      -31     
  Branches      164      164              
==========================================
+ Hits          807      822      +15     
+ Misses        102       64      -38     
+ Partials       25       17       -8     
Flag Coverage Δ
solidity 91.02% <87.50%> (+4.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from ron/fix-quorum-check to main December 22, 2025 16:13
Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Comment on lines -32 to -33

function deposit() external payable {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, originally agents paid/collected fees in v1, and this deposit was here as an explicit way to top up or balance agents. But I think we can remove it now.

@yrong
Copy link
Contributor Author

yrong commented Dec 24, 2025

@copilot Please review this pull request.

Copy link

Copilot AI commented Dec 24, 2025

@yrong I've opened a new pull request, #1666, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants