Brille integration #52
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Modify spinw.m to have a private property `brille` Add @spinw/brille_init.m to initialise and fill the brille grid Modify spinwave.m to have option to use Brille Modify sw_readparam to have option to pass on unknown parameters
Fix incorrect use of hklExt instead of hkl Fix setup and indexing of modes in incommensurate cases Add formfactor calculation for Sab interpolation (assumes that there is only one magnetic species) Add help text for .brille_init Change to use full BZ instead of magnetic BZ for Sab interpolation.
Fix bug in use of Qtrans (was ignored in some cases) Add option for users to specify Qtrans directly Defaults to using full structural cell (not magnetic cell) for Sab Defaults to using full BZ (not irreducible BZ) for incommensurate
mducle
force-pushed
the
brille_integration
branch
from
b0c3e86 to
59887f4
Compare
mducle
force-pushed
the
master
branch
2 times, most recently
from
ec2bf63 to
df2a40d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use
brilleto interpolate eitherSabor the eigenvectors and not have to calculate the Hamiltonian and diagonalise it inspinwave.m