Refactor invoice validation using reusable modifiers

[Sana9058]

What this PR does

This PR refactors repeated require checks in:

• payInvoice
• cancelInvoice
• getPaymentStatus

by extracting them into reusable modifiers:

• validInvoice
• invoiceActive
• onlyCreator
• onlyPayer

Why

• Reduces code duplication
• Improves readability
• Keeps business logic unchanged

Scope

• Refactor only (no functional changes)

Summary by CodeRabbit

• Refactor
  • Strengthened validation and access control across invoice operations
  • Enhanced security checks to prevent unauthorized modifications and payments
  • Improved enforcement of authorization requirements for all invoice actions

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Four new modifiers were introduced to centralize access-control and invoice validation checks. Three functions were refactored to use these modifiers: cancelInvoice, payInvoice, and getPaymentStatus. The batch payment path was updated to align with the new validation flow.

Changes

Cohort / File(s)	Summary
Access Control Refactoring contracts/src/Chainvoice.sol	Added four modifiers (validInvoice, invoiceActive, onlyCreator, onlyPayer) to centralize validation logic. Updated cancelInvoice, payInvoice, and getPaymentStatus functions to apply these modifiers. Batch pay path refactored to integrate new validation flow while preserving CEI pattern.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Modifiers now guard each invoice door,
Access checks centralized, clean and sure,
No more scattered guards throughout the code,
The logic flows in a clearer mode! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: refactoring invoice validation by extracting repeated checks into reusable modifiers, which aligns perfectly with the changeset and PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}