-
-
Notifications
You must be signed in to change notification settings - Fork 89
feat: add stacSliverToBoxAdapter widget, parser,example and documentation #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdds first-class support for SliverToBoxAdapter: a StacSliverToBoxAdapter model with JSON (de)serialization, a parser that renders a Flutter SliverToBoxAdapter, registration of the parser in the framework, WidgetType enum variant, exports, docs, and example gallery assets. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/widgets/sliver_to_box_adapter.mdx`:
- Around line 6-8: Update the prose describing the widget to hyphenate the
compound adjective: replace occurrences of "sliver to box adapter" with
"sliver-to-box-adapter" in the sentence that mentions "The Stac
SliverToBoxAdapter allows you to build a Flutter sliver to box adapter widget
using JSON." Ensure the phrase "sliver-to-box-adapter widget" appears
consistently (e.g., in the line referencing the official documentation) and keep
the class name "SliverToBoxAdapter" unchanged.
In `@packages/stac_core/lib/foundation/specifications/widget_type.dart`:
- Around line 210-211: The doc comment for the enum value sliverToBoxAdapter is
incorrect (it says "Sliver app bar widget"); update the comment above the
sliverToBoxAdapter enum member in widget_type.dart to accurately describe that
it represents a SliverToBoxAdapter widget (e.g., "SliverToBoxAdapter widget" or
similar). Ensure the updated comment is concise and matches the naming/style of
other enum docs in the same file.
packages/stac_core/lib/foundation/specifications/widget_type.dart
Outdated
Show resolved
Hide resolved
|
Hi @divyanshub024 , @Potatomonsta 👋, |
Description
This PR introduces support for
stacSliverToBoxAdapterby adding a new widget model and its corresponding parser.Related Issues
Closes #422
Type of Change
Summary by CodeRabbit
New Features
Documentation
Examples
✏️ Tip: You can customize this high-level summary in your review settings.