-
-
Notifications
You must be signed in to change notification settings - Fork 89
feat: add stacSliverSafeArea widget, parser,example and documentation #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis PR adds a StacSliverSafeArea widget: model, JSON (de)serialization, parser, widget-type registration, documentation, and a gallery example; it also registers the parser in StacService and exports the parser and widget from their barrels. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@packages/stac/lib/src/parsers/widgets/stac_sliver_safe_area/stac_sliver_safe_area_parser.dart`:
- Line 19: The current fallback for model.sliver.parse(context) uses
SizedBox.shrink() which is not a sliver and will crash SliverSafeArea; either
remove the fallback (since model.sliver is non-nullable) or replace it with a
sliver-compatible fallback such as wrapping the box in a SliverToBoxAdapter;
update the expression using model.sliver.parse(context) and ensure
SliverSafeArea receives a RenderSliver-compatible child (refer to the sliver
variable and the SliverSafeArea usage).
Description
This PR introduces support for
stacSliverSafeAreaby adding a new widget model and its corresponding parser.Related Issues
Closes #420
Type of Change
Summary by CodeRabbit
New Features
Documentation
Examples
✏️ Tip: You can customize this high-level summary in your review settings.