EXOSCALE: Migrate to egoscale v3 #3342
Open
+160
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Collaborator
Author
|
Still WIP because I'm testing the change |
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
pierre-emmanuelJ
changed the title
sauterp
approved these changes
Jan 10, 2025
Collaborator
Is this still being tested? Please "convert to draft" if its not ready to be merged. |
Collaborator
Author
|
I'm running the integ test, I'm posting it ASAP |
Collaborator
|
Please rebase (sorry... lots of merges going on this week!) |
Collaborator
|
Friendly ping? |
|
@pierre-emmanuelJ I assume this would also close #1564? |
Collaborator
Author
Thanks will do |
Collaborator
|
Hi @pierre-emmanuelJ, have you had a chance to do the rebase yet? Once that’s done we’ll be able to merge these changes. Thanks a lot for your help! |
Collaborator
|
Friendly reminder to rebase so that this can be merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3327 I adapted your proposed change in this PR