feat: Allow to rotate all nodeplugins at once. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we roll-out an update to csi-rclone, currently, the nodeplugins are deleted and updated one by one: this makes the roll-out slow for no reason. The nodeplugins can instead be all deleted and recreated at the same time for a faster roll-out.
Member
|
Let me see if we can test this 👍 |
rokroskar
reviewed
Jun 20, 2025
| - mountPath: /var/lib/rclone | ||
| name: cache-dir | ||
| updateStrategy: | ||
| type: RollingUpdate |
Member
There was a problem hiding this comment.
don't you just want Recreate here?
Member
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
From my understanding daemonsets support different strategies:
https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/#daemonset-update-strategy and recreate is not one of those.
It might be interesting to see if we can use onDelete along with some Helm black sorcery to automate the process of rotating the nodeplugins when they are not in use...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we roll-out an update to csi-rclone, currently,
the nodeplugins are deleted and updated one by one:
this makes the roll-out slow for no reason.
The nodeplugins can instead be all deleted and recreated
at the same time for a faster roll-out.