feat: use react-select to pick group member role #3906
Conversation
|
You can access the deployment of this PR at https://renku-ci-ui-3906.dev.renku.ch |
ciyer
changed the title
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Nice addition 🚀
Minor change: I suggest we use the standard styling/positioning for dropdown menus, with the label above the input. It looks a little off since there is already another dropdown in the same modal (on the left is the proposal, on the right the current implementation)
ciyer
force-pushed
the
ciyer/explain-group-roles
branch
from
da45455 to
5c8374c
Compare
I agree, it looks better when using the our standard. 
|
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Lgtm! 🚀
I wonder if we should plan to have a similar "select" for project permissions -- perhaps it's less confusing in that case, but the difference between Editor and Owner might not be obvious.
I'll make an issue
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Tiny detail I initially missed
| fieldState: { error }, | ||
| }) => ( | ||
| <> | ||
| <div className={cx("ms-1", "w-100", error && "is-invalid")}> |
There was a problem hiding this comment.
I noticed late this misalignement
| <div className={cx("ms-1", "w-100", error && "is-invalid")}> | |
| <div className={cx("w-100", error && "is-invalid")}> |
Summary
Use a react-select component to set the role for group members. This allows us to show more detailed information about the differences between the roles.
/deploy