Skip to content

refactoring #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mohammad-alisafaee merged 1 commit into from
Dec 3, 2025
Merged

refactoring #4264

mohammad-alisafaee merged 1 commit into from
Dec 3, 2025

Conversation

@mohammad-alisafaee
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee commented Nov 25, 2025

Refactoring:

  • Split and/or merge tests to better cover different resource creation and deletion scenarios.
  • Replace duplicated Cypress UI flows with API-based resource creation where appropriate.
  • Simplify names of data structures and utility functions by removing redundant terms (e.g., API, V2).
  • …

/deploy extra-values=enableInternalGitlab=false renku-ui=build/acceptance-tests

@RenkuBot
Copy link
Collaborator

RenkuBot commented Nov 25, 2025

You can access the deployment of this PR at https://ci-renku-4264.dev.renku.ch

@mohammad-alisafaee mohammad-alisafaee force-pushed the acceptance-test-refactoring branch from 5aa1e65 to a9354c6 Compare November 25, 2025 23:01
@mohammad-alisafaee mohammad-alisafaee marked this pull request as ready for review November 25, 2025 23:01
@mohammad-alisafaee mohammad-alisafaee requested a review from a team as a code owner November 25, 2025 23:01
@mohammad-alisafaee mohammad-alisafaee force-pushed the acceptance-test-refactoring branch from a9354c6 to e70a5c3 Compare November 25, 2025 23:18
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactoring! The code in the test files is now more readable 👍

@mohammad-alisafaee mohammad-alisafaee merged commit 56a3599 into build/acceptance-tests Dec 3, 2025
26 checks passed
@mohammad-alisafaee mohammad-alisafaee deleted the acceptance-test-refactoring branch December 3, 2025 18:16
@RenkuBot
Copy link
Collaborator

RenkuBot commented Dec 3, 2025

Tearing down the temporary RenkuLab deployment for this PR.

mohammad-alisafaee added a commit that referenced this pull request Dec 10, 2025
@mohammad-alisafaee
refactoring (#4264)
ae79d6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees

No one assigned

Labels

acceptance-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohammad-alisafaee @RenkuBot @lorenzo-cavazzi