Chore/convention plugins #2080
Open
Chore/convention plugins #2080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-1squared
force-pushed
the
chore/convention-plugins
branch
7 times, most recently
from
9699bb2 to
ddbd2ca
Compare
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
now that I ran it again for once Signed-off-by: l-1squared <[email protected]>
l-1squared
force-pushed
the
chore/convention-plugins
branch
from
ddbd2ca to
02180c1
Compare
Signed-off-by: l-1squared <[email protected]>
hvennekate
reviewed
Nov 18, 2025
| plugins { | ||
| id 'java-library' | ||
| id('jgiven-checkstyle') | ||
| id('jgiven-java') |
Collaborator
There was a problem hiding this comment.
Stupid question: those two could not be moved into the conventions for technical reasons? Or are there some modules which would not take kindly to them?
hvennekate
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.