-
Notifications
You must be signed in to change notification settings - Fork 7
Accommodate Mbovis reference #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
abhi18av
wants to merge
55
commits into
dev
Choose a base branch
from
feature/mbovis-reference
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22ecd95 to
ba80eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes related to adapting MAGMA pipeline for the
Mbovisrelated analysis.This pull request primarily removes the custom
bwa/memmodule from the codebase, including its process definition, environment, metadata, and tests. It also updates container configuration forSNPEFF, adjusts a reference genome in SNPEFF arguments, and improves parameterization in some local modules. Additionally, it cleans up themodules.jsonfile by removing several module entries.The most important changes are:
Module Removal and Cleanup
bwa/memmodule, including its process definition (main.nf), environment file (environment.yml), metadata (meta.yml), and all associated tests (tests/main.nf.test). [1] [2] [3] [4]modules.jsonby removing references to many modules, includingbwa/mem, and others such asbcftools/merge,samtools/index, and more.Container and Configuration Updates
conf/docker.configto assign a dedicated container image forSNPEFFprocesses, separating it from the general container used for other tools.default_params.configto use theMycobacterium_bovis_gca_000729755reference instead ofMycobacterium_tuberculosis_h37rv.Parameterization Improvements
modules/local/tbprofiler/vcf_profile__cohort.nfandmodules/local/tbprofiler/vcf_profile__lofreq.nfto use theparams.ref_fasta_basenameparameter for better flexibility. [1] [2]