Skip to content

Conversation

@abhi18av
Copy link
Member

@abhi18av abhi18av commented Aug 22, 2024

This PR introduces changes related to adapting MAGMA pipeline for the Mbovis related analysis.

This pull request primarily removes the custom bwa/mem module from the codebase, including its process definition, environment, metadata, and tests. It also updates container configuration for SNPEFF, adjusts a reference genome in SNPEFF arguments, and improves parameterization in some local modules. Additionally, it cleans up the modules.json file by removing several module entries.

The most important changes are:

Module Removal and Cleanup

  • Removed the entire custom bwa/mem module, including its process definition (main.nf), environment file (environment.yml), metadata (meta.yml), and all associated tests (tests/main.nf.test). [1] [2] [3] [4]
  • Cleaned up modules.json by removing references to many modules, including bwa/mem, and others such as bcftools/merge, samtools/index, and more.

Container and Configuration Updates

  • Updated conf/docker.config to assign a dedicated container image for SNPEFF processes, separating it from the general container used for other tools.
  • Changed the SNPEFF arguments in default_params.config to use the Mycobacterium_bovis_gca_000729755 reference instead of Mycobacterium_tuberculosis_h37rv.

Parameterization Improvements

  • Updated hardcoded reference names in modules/local/tbprofiler/vcf_profile__cohort.nf and modules/local/tbprofiler/vcf_profile__lofreq.nf to use the params.ref_fasta_basename parameter for better flexibility. [1] [2]

@abhi18av abhi18av self-assigned this Aug 22, 2024
@abhi18av abhi18av changed the base branch from master to develop August 22, 2024 06:42
@abhi18av abhi18av changed the base branch from develop to dev June 29, 2025 15:32
@abhi18av abhi18av force-pushed the feature/mbovis-reference branch from 22ecd95 to ba80eb4 Compare August 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants