Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/react-start/custom-basepath/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/react-start": "workspace:^",
"express": "^4.21.2",
"express": "^5.0.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1"
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/custom-basepath/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@tanstack/solid-router": "workspace:^",
"@tanstack/solid-router-devtools": "workspace:^",
"@tanstack/solid-start": "workspace:^",
"express": "^4.21.2",
"express": "^5.0.0",
"redaxios": "^0.5.1",
"solid-js": "^1.9.10"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/react/basic-ssr-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@tanstack/react-router": "^1.139.12",
"@tanstack/router-plugin": "^1.139.12",
"compression": "^1.8.0",
"express": "^4.21.2",
"express": "^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Type definitions version mismatch with Express v5.

Express is upgraded to v5.0.0 but @types/express remains at v4.17.23. This causes type incompatibilities and will lead to TypeScript errors or missed type safety issues.

Update @types/express to v5.x to match the express version:

     "@tanstack/router-devtools": "^1.139.12",
-    "@types/express": "^4.17.23",
+    "@types/express": "^5.0.3",

Also applies to: 25-25

🤖 Prompt for AI Agents
In examples/react/basic-ssr-file-based/package.json around lines 17 and 25, the
project lists "express": "^5.0.0" while @types/express is still v4.x, causing
TypeScript mismatch; update the @types/express dependency to a 5.x-compatible
version in package.json (or remove it if using Express's built-in types), then
run your package manager (npm/yarn/pnpm install) to refresh lockfiles and
rebuild TypeScript; ensure any type imports or code paths that rely on v4-only
types are adjusted to the v5 type shapes if necessary.

"get-port": "^7.1.0",
"node-fetch": "^3.3.2",
"react": "^19.0.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/react/basic-ssr-streaming-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@tanstack/react-router": "^1.139.12",
"@tanstack/router-plugin": "^1.139.12",
"compression": "^1.7.5",
"express": "^4.21.2",
"express": "^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Type definitions version mismatch with Express v5.

Express is upgraded to v5.0.0 but @types/express remains at v4.17.21. This causes type incompatibilities and will lead to TypeScript errors or missed type safety issues.

Update @types/express to v5.x to match the express version:

     "compression": "^1.7.5",
     "express": "^5.0.0",
     "get-port": "^7.1.0",

And in devDependencies:

-    "@types/express": "^4.17.21",
+    "@types/express": "^5.0.3",

Also applies to: 25-25

🤖 Prompt for AI Agents
In examples/react/basic-ssr-streaming-file-based/package.json around lines 17
and 25, the project lists "express": "^5.0.0" while still using "@types/express"
v4.x; update the type package to a v5-compatible release to avoid type
mismatches by replacing the current @types/express entry with a matching v5
version (e.g., "^5.0.0" or the latest 5.x) in devDependencies (or dependencies
if present), then run npm/yarn install and re-run TypeScript to confirm no type
errors remain.

"get-port": "^7.1.0",
"node-fetch": "^3.3.2",
"react": "^19.0.0",
Expand Down
1,413 changes: 1,071 additions & 342 deletions examples/react/start-basic-cloudflare/worker-configuration.d.ts

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion examples/react/with-trpc-react-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@trpc/client": "^11.4.3",
"@trpc/server": "^11.4.3",
"@trpc/tanstack-react-query": "^11.4.3",
"express": "^4.21.2",
"express": "^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Type definitions version mismatch with Express v5.

Express is upgraded to v5.0.0 but @types/express remains at v4.17.23. This causes type incompatibilities and will lead to TypeScript errors or missed type safety issues.

Update @types/express to v5.x to match the express version:

     "@trpc/tanstack-react-query": "^11.4.3",
-    "@types/express": "^4.17.23",
+    "@types/express": "^5.0.3",

Also applies to: 31-31

🤖 Prompt for AI Agents
In examples/react/with-trpc-react-query/package.json around lines 22 and 31, the
project lists "express": "^5.0.0" while @types/express is pinned to the v4.x
release, causing TypeScript mismatch; update the dev dependency @types/express
to a v5-compatible release (or remove it if types are included) in package.json,
run npm/yarn install to update lockfile, and verify TypeScript compiles without
type errors.

"postcss": "^8.5.1",
"react": "^19.1.0",
"react-dom": "^19.1.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/react/with-trpc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@tanstack/router-plugin": "^1.139.12",
"@trpc/client": "^11.4.3",
"@trpc/server": "^11.4.3",
"express": "^4.21.2",
"express": "^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Type definitions version mismatch with Express v5.

Express is upgraded to v5.0.0 but @types/express remains at v4.17.23. This causes type incompatibilities and will lead to TypeScript errors or missed type safety issues.

Update @types/express to v5.x to match the express version:

     "@trpc/server": "^11.4.3",
-    "@types/express": "^4.17.23",
+    "@types/express": "^5.0.3",

Also applies to: 28-28

🤖 Prompt for AI Agents
In examples/react/with-trpc/package.json around lines 19 and 28, the project
lists "express": "^5.0.0" while still depending on "@types/express" v4.x which
causes TypeScript mismatches; update the @types/express dependency to a
v5-compatible release (or remove it if Express v5 bundles its own types) in
package.json and run npm/yarn install to refresh lockfile so the installed type
definitions match Express v5.

"postcss": "^8.5.1",
"react": "^19.1.0",
"react-dom": "^19.1.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/solid/basic-ssr-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@tanstack/solid-router": "^1.139.12",
"@tanstack/router-plugin": "^1.139.12",
"compression": "^1.8.0",
"express": "^4.21.2",
"express": "^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Type definitions version mismatch with Express v5.

Express is upgraded to v5.0.0 but @types/express remains at v4.17.23. This causes type incompatibilities and will lead to TypeScript errors or missed type safety issues.

Update @types/express to v5.x to match the express version:

     "@tanstack/solid-router-devtools": "^1.139.12",
-    "@types/express": "^4.17.23",
+    "@types/express": "^5.0.3",

Also applies to: 24-24

🤖 Prompt for AI Agents
In examples/solid/basic-ssr-file-based/package.json around lines 17 and 24, the
project lists "express": "^5.0.0" while @types/express is still at v4.17.23,
causing TypeScript type mismatches; update the @types/express dependency to a
v5-compatible release (or remove it if using express v5's built-in types) in
package.json and run npm/yarn install, then verify TypeScript compiles and
adjust any type imports if the v5 typings changed.

"get-port": "^7.1.0",
"node-fetch": "^3.3.2",
"solid-js": "^1.9.10"
Expand Down
2 changes: 1 addition & 1 deletion examples/solid/basic-ssr-streaming-file-based/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@tanstack/solid-router": "^1.139.12",
"@tanstack/solid-router-devtools": "^1.139.12",
"compression": "^1.7.5",
"express": "^4.21.2",
"express": "^5.0.0",
"get-port": "^7.1.0",
"node-fetch": "^3.3.2",
"postcss": "^8.5.1",
Expand Down
1,413 changes: 1,071 additions & 342 deletions examples/solid/start-basic-cloudflare/worker-configuration.d.ts

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion examples/solid/with-trpc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@tanstack/router-plugin": "^1.139.12",
"@trpc/client": "^11.4.3",
"@trpc/server": "^11.4.3",
"express": "^4.21.2",
"express": "^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Type definitions version mismatch with Express v5.

Express is upgraded to v5.0.0 but @types/express remains at v4.17.23. This causes type incompatibilities and will lead to TypeScript errors or missed type safety issues.

Update @types/express to v5.x to match the express version:

     "@trpc/server": "^11.4.3",
-    "express": "^5.0.0",
+    "@types/express": "^5.0.3",

Note: This appears to show express in dependencies instead of devDependencies. Please verify @types/express placement and version:

   "devDependencies": {
-    "@types/express": "^4.17.23",
+    "@types/express": "^5.0.3",

Also applies to: 27-27

🤖 Prompt for AI Agents
In examples/solid/with-trpc/package.json around lines 19 and 27, the project
lists "express": "^5.0.0" but still uses @types/express v4.x which mismatches
Express v5 and causes TypeScript errors; update the @types/express entry to a
v5.x release (or remove it if types are bundled) and move @types/express into
devDependencies (or ensure the correct devDependency entry exists), then run
npm/yarn install and rebuild to validate types.

"postcss": "^8.5.1",
"solid-js": "^1.9.10",
"redaxios": "^0.5.1",
Expand Down
Loading
Loading