Skip to content

Conversation

@ligustah
Copy link

@ligustah ligustah commented Apr 14, 2025

The comment on animateTo says that offsets are not supported for rotation due to a flutter maps limitation. Before switching to this package, I used just flutter maps and had a working solution that simply called move and rotateAroundPoint together. This appears to be working just fine with the animation as well in my tests.

If you considered merging this, I'd be extremely grateful if you could also backport this into the 0.8 branch 🙏

Thanks!

@TesteurManiak TesteurManiak added the enhancement New feature or request label Apr 14, 2025
@TesteurManiak
Copy link
Owner

Thanks for the contribution!

Regarding the backport request to version 0.8, unfortunately this is something that I'd prefer not doing to avoid breaking the update flow on pub.dev. If you cannot migrate to v0.9 I'm sorry but you'll still have to fork the previous release to maintain it yourself.

If you can update your branch to the latest commit on the main branch I'll gladly review and test it.

@ligustah
Copy link
Author

ligustah commented Apr 14, 2025

Thanks for the contribution!

Regarding the backport request to version 0.8, unfortunately this is something that I'd prefer not doing to avoid breaking the update flow on pub.dev. If you cannot migrate to v0.9 I'm sorry but you'll still have to fork the previous release to maintain it yourself.

If you can update your branch to the latest commit on the main branch I'll gladly review and test it.

Thanks for getting back so quickly!

I can't easily upgrade, unfortunately, due to other dependencies related to flutter_maps. Also, now that I see it, you'll probably want to cherry-pick these two commits into your main branch (or just manually redo the changes), since my changes were based on the v8 tag when I first tested locally. (nvm, didn't read your comment correctly)

Will continue working with a fork for the time being, hoping I can upgrade the other dependencies in time.

@ligustah
Copy link
Author

If you can update your branch to the latest commit on the main branch I'll gladly review and test it.

I can try, but can't easily test until I'll be able to upgrade my project.

@ligustah
Copy link
Author

Rebased on main, but haven't tested it. If you want to hold off on merging, I'll test more extensively once I can upgrade my project to >v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants