Conversation
rustybee42
force-pushed
the
rb/update-rust
branch
3 times, most recently
from
2dd4539 to
482817b
Compare
rustybee42
force-pushed
the
rb/update-rust
branch
from
482817b to
05391a5
Compare
rustybee42
force-pushed
the
rb/update-rust
branch
from
05391a5 to
56a2057
Compare
iamjoemccormick
approved these changes
Dec 19, 2025
Member
iamjoemccormick
left a comment
iamjoemccormick
left a comment
There was a problem hiding this comment.
LGTM.
My only recommendation would be to make sure all the integration tests still pass in case the dependency updates bring any behavior changes (which they shouldn't if they follow semver). That will happen automatically once this is merged so no concerns from me.
* Fix prost to 0.13 as 0.14 is incompatible with the generated protobuf code * Fix daemonize to 0.5.0 * Fix breaking changes
rustybee42
force-pushed
the
rb/update-rust
branch
from
56a2057 to
33e10e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Rust 1.90, lld is used as linker instead of ld on x86 targets by default.
lldis much quicker, so we get improved build times.With Rust 1.88 / GNU ld:
With Rust 1.90, lld:
The linking time is roughly cut in half. While not that impactful on a full rebuild, it cuts a partial rebuild of only the management (e.g. during development) by around 25% from around 15 seconds to around 11.5 seconds on my machine.