Fix: Include column types in Databricks materialized views with comments #5578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Databricks requires column types to be specified when adding column comments in CREATE MATERIALIZED VIEW statements. Without the column types, the comments are silently ignored. This change adds a Databricks-specific override of _build_column_defs that forces column types to be included when creating views with column descriptions.
Verifies that column types are included in CREATE MATERIALIZED VIEW statements when column comments are present, as required by Databricks.
|
|
izeigerman
reviewed
Nov 7, 2025
| # in CREATE MATERIALIZED VIEW statements. Override is_view to False to force | ||
| # column types to be included when comments are present. | ||
| if is_view and column_descriptions: | ||
| engine_supports_schema_comments = self.COMMENT_CREATION_VIEW.supports_schema_def |
Member
There was a problem hiding this comment.
Do we even need this check here provided that we know that this will always be true for Databricks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
type definitions
statements when column comments are present
Technical Details
The fix overrides the
is_viewparameter toFalsewhen building column definitions formaterialized views that have column comments. This ensures the base class includes column types
in the schema definition, which Databricks requires for this scenario.
Let me know if we should take do another approach for this.