-
Notifications
You must be signed in to change notification settings - Fork 40
Stock and Flow with Auxiliary Variables #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4914bbd to
71cc0ea
Compare
packages/catlog-wasm/src/theories.rs
Outdated
|
|
||
| /// Simulates the mass-action system derived from a model. | ||
| #[wasm_bindgen(js_name = "mass_action")] | ||
| pub fn mass_action( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove for now until we have an idea about semantics for system structure diagrams with auxiliary: the existing mass action semantics will not use the auxiliary variables at all.
| ustr("Outflow"), | ||
| TabObType::Basic(x), | ||
| th.tabulator(th.hom_type(TabObType::Basic(x))), | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed today, these "inflows" and "outflows" are actually new kinds of links. We decided to punt on inflows/outflows until our theories can be souped up to handle terminal objects.
This PR introduces an extension of Stock and Flow with auxiliary variables, an object which acts as a functions of quantities of stocks connected to it by variable links. The auxiliary variable acts on flows by a flow link. This effort implements the theory and frontend partially completed in #537, whereas the simulation work will be punted to a new PR.