-
Notifications
You must be signed in to change notification settings - Fork 40
Run all frontend tests in CI with NixOS VM #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a3dd7c to
79aa62c
Compare
194317b to
c272965
Compare
c6c10b5 to
65cb065
Compare
6b53dd6 to
4ee768f
Compare
4ee768f to
f0472f9
Compare
epatters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jason, it will be great to run the full test suite in CI. Two questions/comments below.
f1fd738 to
f74bc73
Compare
510c446 to
5d8701a
Compare
1fbff4f to
51b7a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jason, I tried reverting the changes to the pnpm lock file caused by accidentally adding jsdom and now I'm getting a hash mismatch that I can't figure out how to fix. Can you fix this and also remind me what I should do in the future?
|
I pushed a fix. Steps:
I'll make sure to improve the docs on this
It's possible that there was another instance of something changing and the hash not getting updated. Fortunately this PR should prevent that going forward. |
This creates:
vitesttests from thefrontendpackage.This result is end-to-end tests against a host that was setup from scratch.
I needed to bump the
vitestversion and some follow on dependencies to letvitestrun in a read-only environment.