-
Notifications
You must be signed in to change notification settings - Fork 40
Redesign of Julia interop, avoiding Jupyter kernel #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kris-brown
wants to merge
6
commits into
main
Choose a base branch
from
interop_refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
967ea9f to
113a4f8
Compare
b9eb474 to
4d6e69e
Compare
CLEANUP: changing tests CLEANUP: reorganized code into parse and execute folders refactor algjuliainterop CORS and async issues resolved basic tabular view functionality edit remove decapodes material
4d6e69e to
3b4ce9b
Compare
kasbah
reviewed
Dec 22, 2025
Comment on lines
+120
to
+130
| async ([model, diagram]) => { | ||
| const response = await axios.post( | ||
| "http://127.0.0.1:8080/acsetcolim", | ||
| { | ||
| model: model?.presentation(), | ||
| diagram: diagram?.presentation(), | ||
| }, | ||
| config, | ||
| ); | ||
| return response.data; | ||
| }, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to do this without axios, using native fetch instead. It's a bit more code but also more explicit about what's going on. Something like:
async ([model, diagram]) => {
const response = await fetch(
"http://127.0.0.1:8080/acsetcolim",
{
method: "POST",
headers: {
"Content-Type": "application/json",
...config.headers,
},
body: JSON.stringify({
model: model?.presentation(),
diagram: diagram?.presentation(),
})
},
);
if (!response.ok) {
throw new Error(`HTTP error! status: ${response.status}`);
}
return response.json();
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies a lot of the structure of the CatColabInterop.jl package.
It introduces a new analysis of schema instances by sending the diagram to Catlab, where it is processed by
@acset_colimto produce a tabular instance.(This is currently a WIP - once the workflow is working for the tabular view analysis, the existing Decapodes analysis will be brought back into functionality).