Improves GitHub Actions workflow #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moving `built/` code to `.gitignore` - `built/` removed from VC - `npm run build` run via postinstall hook - `actions/setup-node` added to workflow so code is built in CI
Member
|
Built files are intentionally committed so people can download theme repositories as zips from github and upload them directly to Ghost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used an earlier version of Starter for a project recently and noticed the CI wasn't working as expected. From this I realised that it's not actually building the code in CI or installing dependencies.
This PR improves the GitHub Actions workflow by:
built/code to.gitignorebuilt/removed from VCnpm run buildrun via postinstall hookactions/setup-nodeadded to workflow so code is built in CI