Fix rustapi-grpc documentation for direct usage and add explicit Tokio features#119
Closed
Copilot wants to merge 2 commits intogrpc-and-so-manyfrom
Closed
Fix rustapi-grpc documentation for direct usage and add explicit Tokio features#119Copilot wants to merge 2 commits intogrpc-and-so-manyfrom
Copilot wants to merge 2 commits intogrpc-and-so-manyfrom
Conversation
13 tasks
- Add explicit Tokio features (rt, sync) to Cargo.toml - Update crate-level docs to show direct rustapi_grpc usage first - Add Usage section to README distinguishing rustapi-rs vs direct usage - Update all examples to use rustapi_grpc + rustapi_core imports Co-authored-by: Tuntii <121901995+Tuntii@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add optional rustapi-grpc crate for gRPC integration
Fix rustapi-grpc documentation for direct usage and add explicit Tokio features
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #118:
rustapi-grpcexamples imported fromrustapi_rs::grpc, making them unusable for direct crate consumers, and lacked explicit Tokio feature declarations.Documentation updates:
rustapi_grpc+rustapi_coreimports (copy-pasteable for direct users)run_rustapi_and_grpc_with_shutdown) also updatedDependency improvements:
rt,sync,macros(follows pattern inrustapi-core,rustapi-extras,rustapi-ws)Before (confusing for direct users):
After (works for both direct and facade users):
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.