-
Notifications
You must be signed in to change notification settings - Fork 0
정적타입 도입을 위한 Typescript 마이그레이션 및 리팩토링(migration/typescript) #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Twince
wants to merge
32
commits into
develop
Choose a base branch
from
migration/typescript
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기존 faet/query에 추가해야할 커밋이었으나, 빌드 및 패키지 매니저의 추가로 환경 설정이 불편하여 해당 브랜치에 그대로 추가. (브랜치 스위칭하는데 더 큰 비용이 들 것 같음)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
migration
refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request (migration/typescript)
정적타입 도입을 위한 마이그레이션 작업을 진행하였습니다.
주요작업
Vite및pnpm을 추가하였습니다.eslint와prettier를 추가하였습니다.Typescript를 도입하였습니다.jsconfig,tsconfig,vite.config) - src root 기준으로@/사용리팩토링 및 기능추가
BoundingBox의 캡슐화 유지를 위해 getter를 추가하였습니다.DrawingEventHandler의 선언부를QueryProcessHandler에서AppController로 변경하였습니다.