feat: added risiko.cpp #420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picred
reviewed
Oct 31, 2025
Comment on lines
+152
to
+157
| cin >> turns; | ||
| cout << endl; | ||
| while(cin.fail() || turns <= 0){ | ||
| cerr << "ERROR! Turns need to be an integer greater than 0, retry." << endl; | ||
| cin >> turns; | ||
| } |
There was a problem hiding this comment.
Avresti potuto evitare delle istruzioni superflue con un do while();
There was a problem hiding this comment.
L'ho fatto in modo tale da mettere in evidenza l'errore all'utente e permettergli di reinserire il valore corretto senza dover ricominciare il programma da capo. Non lo so se con il do while() avrei ottenuto lo stesso risultato e forse sarebbero servite più linee di codice. In caso come avrei dovuto procedere?
Helias
reviewed
Nov 1, 2025
| #include <ctime> | ||
| using namespace std; | ||
|
|
||
| //Class Player |
Helias
reviewed
Nov 1, 2025
| cerr << "ERROR! Players can't share the same colour, retry." << endl; | ||
| } | ||
| else{ | ||
| check = true; |
There was a problem hiding this comment.
probabilmente puoi rimuovere la variabile check, potresti usare while(player_1 !== player_2), oppure usi while true e metti un break; al posto di check = true;
Non è il massimo usare while (true) o break, quindi opterei più per la prima soluzione
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.