feat(verify.py): implemented function verify and its test #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/verify.py
Outdated
| @@ -0,0 +1,6 @@ | |||
| def verify(l:list[int], v:int ) -> bool: | |||
There was a problem hiding this comment.
Sarebbe meglio usare dei nomi più descrittivi sia per il nome della funzione (es: is_element_in_list oppure list_contains), sia per i parametri in ingresso(che chiamerei senza abbreviazione list e value), in modo che, semplicemente leggendo la firma della funziona, si intuisca cosa si aspetta in input, cosa ci aspettiamo che faccia e cosa eventualmente ritorna come output.
In questo caso potrebbe sembrare superfluo perché la funzione è banale, tuttavia è una buona abitudine che è meglio acquisire il prima possibile :)
FilippoMarletta
force-pushed
the
implement-verify
branch
from
7e8be4e to
8189f28
Compare
TendTo
requested changes
Nov 8, 2023
TendTo
approved these changes
Nov 8, 2023
simone989
reviewed
Nov 9, 2023
tests/test_is_element_in_list.py
Outdated
|
|
||
| def test_is_element_in_list() -> None: | ||
| assert is_element_in_list([1,2,3], 2) == True | ||
| assert is_element_in_list([1,2,3], 4) == False |
There was a problem hiding this comment.
Definisci l'array di elementi [1,2,3] in una costante
There was a problem hiding this comment.
ho parametrizzato tutto, va bene così?
commit
Helias
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impementented function verify to check whether an int value belongs to a list of integers and implemented its test