Skip to content

fix: v2.4.1 NGO update #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: v2.4.1 NGO update #913

wants to merge 1 commit into from

Conversation

@NoelStephensUnity
Copy link
Contributor

@NoelStephensUnity NoelStephensUnity commented Jun 16, 2025

Description

Since NGO v2.4.1 and above will now house testhelpers within the runtime tests assembly, we need to add the Unity.Netcode.Runtime.Tests to the BossRoom's tests asmdef.

Issue Number(s)

NA

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@NoelStephensUnity
fix
7867815 
Since NGO v2.4.1 and above will now house testhelpers within the runtime tests assembly, we need to add the Unity.Netcode.Runtime.Tests to the BossRoom's tests asmdef.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 16, 2025 13:46
@unity-cla-assistant
Copy link

unity-cla-assistant commented Jun 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@NoelStephensUnity
Copy link
Contributor Author

NoelStephensUnity commented Jun 17, 2025 •
edited
Loading

closing this PR after rebasing issue.

@NoelStephensUnity NoelStephensUnity force-pushed the fix/ngo-2-4-1-update-testhelpers branch from 7867815 to c19318f Compare June 17, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NoelStephensUnity @unity-cla-assistant