Php setup fix and stopping members pages being (as) slow #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason hasDependency and isAwardedTo slow the page down - this just means that unnecessary testing is avoided by putting the quicker tests earlier
Comment on lines
+315
to
+317
| if ($status->canAward($by) | ||
| && $status->hasDependency($to) | ||
| && $status->canAward($by) | ||
| && (!$status->isAwardedTo($to)) |
Contributor
Author
There was a problem hiding this comment.
For some reason if you run canAward without the other tests it runs smoothly. Obviously I can't just remove the tests so I just put that one first so when that fails it doesn't test the other ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.