Skip to content

feat: client identification headers #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat: client identification headers #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c2549a
feat: client identification headers
kwasniew Jan 22, 2025
95cda65
feat: build config for version
kwasniew Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions unleashandroidsdk/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ android {
namespace = "io.getunleash.android"
compileSdk = 34

buildFeatures {
buildConfig = true
Copy link
Contributor Author

@kwasniew kwasniew Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable build config that auto generated BuildConfig file

}

defaultConfig {
minSdk = 21

Expand All @@ -30,6 +34,8 @@ android {
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("proguard-rules.pro")

buildConfigField("String", "VERSION", "\"${project.version}\"")
Copy link
Contributor Author

@kwasniew kwasniew Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add custom VERSION field to the BuildConfig

}

buildTypes {
Expand Down
3 changes: 3 additions & 0 deletions unleashandroidsdk/src/main/java/io/getunleash/android/UnleashConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@ data class UnleashConfig(
"Authorization" to auth,
"Content-Type" to "application/json",
"UNLEASH-APPNAME" to appName,
Copy link
Contributor Author

@kwasniew kwasniew Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be deprecated after expand/contract period

"X-UNLEASH-APPNAME" to appName,
"User-Agent" to appName,
"UNLEASH-INSTANCEID" to instanceId,
"X-UNLEASH-CONNECTION-ID" to instanceId,
Copy link
Contributor

@gastonfournier gastonfournier Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we can deprecate UNLEASH-INSTANCEID header, as this connection id seems to be fulfilling the same purpose. We should open that conversation, but definitely outside of this PR scope

"X-UNLEASH-SDK" to "unleash-client-android:" + BuildConfig.VERSION,
))
}

Expand Down
Loading