feat: ability to dynamically stop listening to events #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Gives users the ability to stop listening to events.
Closes #120
Implementation options
One alternative to this implementation was to return a cancellation/registration handle:
Instead of requiring callers to call removeUnleashEventListener(listener), addUnleashEventListener would return a lightweight registration object (Disposable/ListenerRegistration or a Job) that the caller cancels/disposes to stop that specific listener.
As a user, I think it's simpler to declare my listeners, attach them, and detach them at will, keeping a reference to them, rather than having to reference an object returned by the SDK.