fix: network status crashes #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SecurityException) whenConnectivityManager.registerNetworkCallbackis invoked on startup (Android 11 ConnectivityManager crash #140).IllegalArgumentException: NetworkCallback was already unregisteredwhen clients callDefaultUnleash.close()defensively (NetworkCallback was already unregistered when calling DefaultUnleash.close() #139).Fixes #139
Fixes #140
What’s Changed
close()runs (NetworkStatusHelper).close()now clears tracked callbacks, catches redundantunregisterNetworkCallbackexceptions, and suppresses security errors so repeated close calls are safe.Testing