fix: retry all streaming errors #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
commented
Dec 19, 2024
|
|
||
| const before = repo.getToggles(); | ||
| t.deepEqual(before, []); | ||
| t.deepEqual(before, [{ ...feature, name: 'initialFetch' }]); |
There was a problem hiding this comment.
test showing initial fetch is outside of the streaming flow
kwasniew
commented
Dec 19, 2024
| // first connection is ignored, since we do regular fetch | ||
| eventSource.emit('unleash-connected', { | ||
| type: 'unleash-connected', | ||
| data: JSON.stringify({ meta: {}, features: [{ ...feature, name: 'intialConnectedIgnored' }] }), |
There was a problem hiding this comment.
show that initial streaming connect is ignored
thomasheartman
previously approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Improving retry on streaming behavior.
Previously we were only retrying on 500 codes.
Details:
Important files
Discussion points