Fix switch to polling #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
commented
Sep 8, 2025
| } | ||
|
|
||
| async start(): Promise<void> { | ||
| this.stopped = false; |
Contributor
Author
There was a problem hiding this comment.
this was a bug preventing updates after switching from streaming to polling multiple times
kwasniew
commented
Sep 8, 2025
| export class StreamingFetcher extends EventEmitter implements FetcherInterface { | ||
| private eventSource: EventSource | undefined; | ||
|
|
||
| private stopped = false; |
Contributor
Author
There was a problem hiding this comment.
we don't need this variable in streaming since we have event listener that we register and unregister
kwasniew
commented
Sep 8, 2025
| t.is(repo.getMode(), 'polling'); | ||
| t.true(eventSource.closed); | ||
|
|
||
| await repo.fetch(); |
Contributor
Author
There was a problem hiding this comment.
the test will now work without manual fetch trigger and based on the mode change alone
Pull Request Test Coverage Report for Build 17553138244Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When switching from streaming to polling and polling was previously stopped we need to start it again.
Also changed mode change event after switchover is successful.
Important files
Discussion points