Skip to content

refactor: make impossible metric types impossible #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

refactor: make impossible metric types impossible #768

merged 1 commit into from
Sep 25, 2025

Conversation

@kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Sep 25, 2025 •
edited
Loading

About the changes

Improve metric typing to make impossible metric types impossible

Important files

Discussion points

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18010393997

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.931%
Totals Coverage Status
Change from base Build 17975913558: 0.0%
Covered Lines: 1267
Relevant Lines: 1348
💛 - Coveralls

@kwasniew kwasniew merged commit 75b63da into main Sep 25, 2025
6 checks passed
@kwasniew kwasniew deleted the metric-type-correctness-improvements branch September 25, 2025 14:17
@github-project-automation github-project-automation bot moved this from New to Done in Issues and PRs Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kwasniew @coveralls