Skip to content

Conversation

@sgrossberndt
Copy link
Contributor

No description provided.

@sgrossberndt
Copy link
Contributor Author

The documentation section was accidentally added to the release/2.0 branch first instead of develop. Add it to develop as well.


## GitHub Repository
Download the XSD schema files and examples in the git repository found at https://github.com/VDVde/OJP and take a look at the [documentation tables](https://vdvde.github.io/OJP/index.html).
Download the XSD schema files and examples in the git repository found at [https://github.com/VDVde/OJP](https://github.com/VDVde/OJP).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Download the XSD schema files and examples in the git repository found at [https://github.com/VDVde/OJP](https://github.com/VDVde/OJP).
Download the XSD schema files and examples from the git repository found at [https://github.com/VDVde/OJP](https://github.com/VDVde/OJP).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trurlurl It would have been nice to have had these corrections already in pull request #461, which was open for 11 months and which you approved, but it is what it is :-) Now we have to bring these corrections into the release/2.0 branch again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagined that we could introduce it just for the future and leave it for 2.0, thus having this small difference. But the problem is really minor, I have absolutely no problem if you prefer merging it just like that.

## GitHub Repository
Download the XSD schema files and examples in the git repository found at https://github.com/VDVde/OJP and take a look at the [documentation tables](https://vdvde.github.io/OJP/index.html).
Download the XSD schema files and examples in the git repository found at [https://github.com/VDVde/OJP](https://github.com/VDVde/OJP).
The [documentation tables](https://vdvde.github.io/OJP/index.html) are generated for each relevant branch automatically (when the branch itself is valid).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The [documentation tables](https://vdvde.github.io/OJP/index.html) are generated for each relevant branch automatically (when the branch itself is valid).
The [documentation tables](https://vdvde.github.io/OJP/index.html) are generated for each relevant branch automatically (provided the branch itself is valid).

@ue71603 ue71603 added the bug Something isn't working label Aug 26, 2025
@ue71603 ue71603 requested a review from skinkie August 26, 2025 12:23
@ue71603 ue71603 added this to the v2.0.1 milestone Aug 26, 2025
@trurlurl trurlurl self-requested a review August 27, 2025 09:36
@sgrossberndt sgrossberndt merged commit 482625c into develop Aug 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants